Use scoped bindings for Octane compatibility#509
Merged
arukompas merged 2 commits intoMar 15, 2026
Merged
Conversation
arukompas
approved these changes
Mar 15, 2026
Contributor
|
Thanks a lot @faraweilyas ! Tagged new release v3.24.0 - https://github.com/opcodesio/log-viewer/releases/tag/v3.24.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the service container bindings in
LogViewerServiceProviderfrombind/singletontoscoped.Why is this change necessary?
When running Log Viewer in a Laravel Octane environment (FreankenPHP, Swoole, RoadRunner, etc.), the application container persists between requests. Using standard bindings for services like
LogViewerServiceorLogTypeRegistrarcan cause issues when using custom resolvers.Because the resolver logic often depends on the current request state, using
scopedensures that:Changes
log-viewerbinding toscoped.log-viewer-cachebinding toscoped.LogTypeRegistrarbinding toscoped.References:
Proposed Code Changes
Octane Use Case / Reproduction
In a Laravel Octane environment, the Application container is booted once and stays in memory. When using a custom host resolver like the one below, standard
bindorsingletonregistrations can cause theLogViewerServiceto hold onto state from the very first request that initialized it.By switching to
$this->app->scoped(), we guarantee that theLogViewerServiceis re-resolved from the container at the start of every Octane "sandbox" request, while still maintaining singleton-like behavior within the duration of that single request.